Merge lp:~olivier-martin/lightdm/fixed-gasyncresultiface into lp:lightdm

[Olivier Martin]

configure.ac: Modules gio-2.0 needs to be at least 2.34

GAsyncResultIface.is_tagged used by liblightdm-gobject
has been added to 2.34 in commit:

commit 82d914d808c616d14d489c0272c6d5afc4bfbd5a
Author: Dan Winship <email address hidden>
Date: Thu May 10 11:09:52 2012 -0400
Title: gio: add g_async_result_is_tagged()

[Robert Ancell (robert-ancell)]

We just have this method returning FALSE. Looking at glib/gio/g_async_result_is_tagged if we just don't add this method it should have the same result. Was there anything else thatwas requiring gio 2.34?

review: Needs Information

[Olivier Martin (olivier-martin)]

I am building lightdm from 'Ubuntu 12.04.4 LTS'.

GAsyncResultIface.is_tagged attribute is not available in the Glib I/O
library (version 2.32.4) from this version.
./configure did not report me any issue but I had a build error when
building lightdm.

On 26 June 2014 23:25, Robert Ancell <email address hidden> wrote:

> Review: Needs Information
>
> We just have this method returning FALSE. Looking at
> glib/gio/g_async_result_is_tagged if we just don't add this method it
> should have the same result. Was there anything else thatwas requiring gio
> 2.34?
> --
>
> https://code.launchpad.net/~olivier-martin/lightdm/fixed-gasyncresultiface/+merge/224730
> You are the owner of lp:~olivier-martin/lightdm/fixed-gasyncresultiface.
>

[Robert Ancell (robert-ancell)]

Right - I'm just thinking the best solution might be to remove this code rather than bump the minimum requirement.

[lp:~olivier-martin/lightdm/fixed-gasyncresultiface]

2004. By Olivier Martin on 2014-06-27

liblightdm-gobject: Enabled the library for lower Glib I/O versions

Removed GAsyncResultIface.is_tagged as this attribute was not available
in earlier versions of Glib I/O.

[Olivier Martin (olivier-martin)]

Anything missing in this patch?

review: Needs Resubmitting

[Robert Ancell (robert-ancell)]

review: Approve

=== modified file 'liblightdm-gobject/greeter.c'
--- liblightdm-gobject/greeter.c	2014-05-28 20:23:37 +0000
+++ liblightdm-gobject/greeter.c	2014-06-27 08:51:28 +0000
@@ -1916,16 +1916,9 @@
     return NULL;
 }
 
-static gboolean
-request_is_tagged (GAsyncResult *res, gpointer source_tag)
-{
-    return FALSE;
-}
-
 static void
 request_iface_init (GAsyncResultIface *iface)
 {
     iface->get_user_data = request_get_user_data;
     iface->get_source_object = request_get_source_object;
-    iface->is_tagged = request_is_tagged;
 }