Merge lp:~olivier-martin/lightdm-gtk-greeter/lightdm-gtk-greeter-set-message-label-type into lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk

Proposed by Olivier Martin
Status: Merged
Merged at revision: 291
Proposed branch: lp:~olivier-martin/lightdm-gtk-greeter/lightdm-gtk-greeter-set-message-label-type
Merge into: lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk
Diff against target: 93 lines (+14/-10)
1 file modified
src/lightdm-gtk-greeter.c (+14/-10)
To merge this branch: bzr merge lp:~olivier-martin/lightdm-gtk-greeter/lightdm-gtk-greeter-set-message-label-type
Reviewer Review Type Date Requested Status
LightDM Gtk+ Greeter Development Team Pending
Review via email: mp+224789@code.launchpad.net

Description of the change

set_message_label(): Extended to use the type of the message (ie: INFO or ERROR)

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/lightdm-gtk-greeter.c'
--- src/lightdm-gtk-greeter.c 2014-06-09 15:49:08 +0000
+++ src/lightdm-gtk-greeter.c 2014-06-27 10:50:52 +0000
@@ -791,8 +791,13 @@
791}791}
792792
793static void793static void
794set_message_label (const gchar *text)794set_message_label (LightDMMessageType type, const gchar *text)
795{795{
796 if (type == LIGHTDM_MESSAGE_TYPE_INFO) {
797 gtk_info_bar_set_message_type(info_bar, GTK_MESSAGE_INFO);
798 } else {
799 gtk_info_bar_set_message_type(info_bar, GTK_MESSAGE_ERROR);
800 }
796 gtk_widget_set_visible (GTK_WIDGET (info_bar), g_strcmp0 (text, "") != 0);801 gtk_widget_set_visible (GTK_WIDGET (info_bar), g_strcmp0 (text, "") != 0);
797 gtk_label_set_text (message_label, text);802 gtk_label_set_text (message_label, text);
798}803}
@@ -1120,7 +1125,7 @@
1120 {1125 {
1121 cancelling = TRUE;1126 cancelling = TRUE;
1122 lightdm_greeter_cancel_authentication (greeter);1127 lightdm_greeter_cancel_authentication (greeter);
1123 set_message_label ("");1128 set_message_label (LIGHTDM_MESSAGE_TYPE_INFO, "");
1124 }1129 }
11251130
1126 /* Make sure password entry is back to normal */1131 /* Make sure password entry is back to normal */
@@ -1179,7 +1184,7 @@
11791184
1180 if (!lightdm_greeter_start_session_sync (greeter, session, NULL))1185 if (!lightdm_greeter_start_session_sync (greeter, session, NULL))
1181 {1186 {
1182 set_message_label (_("Failed to start session"));1187 set_message_label (LIGHTDM_MESSAGE_TYPE_ERROR, _("Failed to start session"));
1183 start_authentication (lightdm_greeter_get_authentication_user (greeter));1188 start_authentication (lightdm_greeter_get_authentication_user (greeter));
1184 }1189 }
1185 g_free (session);1190 g_free (session);
@@ -1406,7 +1411,7 @@
14061411
1407 g_free (user);1412 g_free (user);
1408 }1413 }
1409 set_message_label ("");1414 set_message_label (LIGHTDM_MESSAGE_TYPE_INFO, "");
1410}1415}
14111416
1412static const gchar*1417static const gchar*
@@ -1448,7 +1453,7 @@
1448 {1453 {
1449 /* FIXME: this doesn't show multiple messages, but that was1454 /* FIXME: this doesn't show multiple messages, but that was
1450 * already the case before. */1455 * already the case before. */
1451 set_message_label (message->text);1456 set_message_label (message->type.message, message->text);
1452 continue;1457 continue;
1453 }1458 }
14541459
@@ -1468,7 +1473,7 @@
1468 str = g_strndup (str, strlen (str) - 2);1473 str = g_strndup (str, strlen (str) - 2);
1469 else if (g_str_has_suffix (str, ":"))1474 else if (g_str_has_suffix (str, ":"))
1470 str = g_strndup (str, strlen (str) - 1);1475 str = g_strndup (str, strlen (str) - 1);
1471 set_message_label (str);1476 set_message_label (LIGHTDM_MESSAGE_TYPE_INFO, str);
1472 if (str != message->text)1477 if (str != message->text)
1473 g_free (str);1478 g_free (str);
1474 }1479 }
@@ -1494,7 +1499,7 @@
14941499
1495 gtk_widget_set_sensitive (GTK_WIDGET (username_entry), FALSE);1500 gtk_widget_set_sensitive (GTK_WIDGET (username_entry), FALSE);
1496 gtk_widget_set_sensitive (GTK_WIDGET (password_entry), FALSE);1501 gtk_widget_set_sensitive (GTK_WIDGET (password_entry), FALSE);
1497 set_message_label ("");1502 set_message_label (LIGHTDM_MESSAGE_TYPE_INFO, "");
1498 prompt_active = FALSE;1503 prompt_active = FALSE;
14991504
1500 if (lightdm_greeter_get_is_authenticated (greeter))1505 if (lightdm_greeter_get_is_authenticated (greeter))
@@ -1580,11 +1585,11 @@
1580 if (prompted)1585 if (prompted)
1581 {1586 {
1582 if (get_message_label()[0] == 0)1587 if (get_message_label()[0] == 0)
1583 set_message_label (_("Incorrect password, please try again"));1588 set_message_label (LIGHTDM_MESSAGE_TYPE_ERROR, _("Incorrect password, please try again"));
1584 start_authentication (lightdm_greeter_get_authentication_user (greeter));1589 start_authentication (lightdm_greeter_get_authentication_user (greeter));
1585 }1590 }
1586 else1591 else
1587 set_message_label (_("Failed to authenticate"));1592 set_message_label (LIGHTDM_MESSAGE_TYPE_ERROR, _("Failed to authenticate"));
1588 }1593 }
1589}1594}
15901595
@@ -2753,7 +2758,6 @@
2753 /* Add InfoBar via code for GTK+2 compatability */2758 /* Add InfoBar via code for GTK+2 compatability */
2754 infobar_compat = GTK_WIDGET(gtk_builder_get_object(builder, "infobar_compat"));2759 infobar_compat = GTK_WIDGET(gtk_builder_get_object(builder, "infobar_compat"));
2755 info_bar = GTK_INFO_BAR (gtk_info_bar_new());2760 info_bar = GTK_INFO_BAR (gtk_info_bar_new());
2756 gtk_info_bar_set_message_type(info_bar, GTK_MESSAGE_ERROR);
2757 gtk_widget_set_name(GTK_WIDGET(info_bar), "greeter_infobar");2761 gtk_widget_set_name(GTK_WIDGET(info_bar), "greeter_infobar");
2758 content_area = gtk_info_bar_get_content_area(info_bar);2762 content_area = gtk_info_bar_get_content_area(info_bar);
27592763

Subscribers

People subscribed via source and target branches