Code review comment for lp:~oliver-joos/zim/selection-fixes

Just setting an attribute in __init__ sounds good. And everything can stay within the search dialog! But I'd prefer a new method in class SearchDialog to run an actual search. IMHO it seems not so obvious that searching is just a side-effect of show_all().

Could you please have a look at my branch https://code.launchpad.net/~oliver-joos/zim/enhanced_search? It heavily depends on the current code of SearchDialog and would be affected from bigger changes.

I'd also welcome some comments from you about my plans for enhanced_search (see branch details). And if you like the current state of the branch, I could set it to mature and open a new branch for the enhanced search plugin. The first part is finished, whereas the plugin could take longer.