Code review comment for lp:~oliver-joos/zim/selection-fixes

I see what you mean. It seems that the Firefox page and its find-in-page field have separate selections, whereas Zim can only have one visible selection. Changing this could be a bigger task, and that's not worth the benefit.

I solved it simply be re-using Zims way of highlighting all matches. If "Highlight" is enabled then my fix makes not a big difference. If it is disabled then (as you wrote) my fix makes the current-match selection a bit more stubborn, but only like if "Highlight" was enabled. And if find-in-page is closed then any match selections are gone - with or without Highlight and with or without my fix.

Do you think I should change my branch? E.g. I could limit the "make the current match yellow" part to be only applied if Highlight is enabled.