Code review comment for lp:~oliver-joos/zim/selection-fixes

Yes, this branch does still select the match with a normal selection. But a selection only is quite volatile:

Select a word and press Ctrl+F => cursor and selection will jump to the InputEntry of the FindBar. You can't see where your current match is, and you have to remember/guess where you get by pressing "Next" or "Previous". You may jump a few words or scroll down dozens of lines. Activating "Highlight" improves it a bit, as you then see the potential matches. But the current match is still not visible, whenever something else gets selected.

My branch solves it like Firefox and Chromium do. Although Firefox (at least 3.x) has quite funny colors: green for the current match and purple to highlight other matches. Chromium looks better with yellow and orange. Zim has orange to highlight, so I chose a dark yellow for the current match, different enough from the bright yellow of Marked text. To me it feels more predictable/less volatile than with the selection only.