Code review comment for lp:~oldmanuk/gwibber/twitter-user-messages-tab

Revision history for this message
Ryan Paul (segphault) wrote :

I'm pretty comfortable with your implementation. I think it's fine to merge this now. I'd like to have it fully supported for identi.ca/laconi.ca too before 1.0.

At some point in the future, I think it would be advantageous to have a single config item in the preference dialog that the users can toggle to specify whether links should load in tabs within the client or in their browser. This option should be applicable to search, tag, group, user, etc.

review: Approve

« Back to merge proposal