Code review comment for lp:~olafvdspek/drizzle/refactor11
Revision history for this message
| Olaf van der Spek (olafvdspek) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Wed, Nov 16, 2011 at 10:08 AM, Brian Aker <email address hidden> wrote:
> @Olaf I'd leave the atomic implementation alone. This is an area where in the future someone could want what you are removing (and what has tests).
I'll restore the tests to test the pthread implementation.
But what removed code could someone want in the future?
> re: query_id
> Right now it is one step closer to being encapsulated for catalogs, why remove that?
How does it relate to catalogs?
Olaf