Code review comment for lp:~oif-team/geis/event-control-functions

Revision history for this message
Chase Douglas (chasedouglas) wrote :

I didn't realize the merge proposal had been updated :(.

After reviewing the code again, I realized that GeisEvent is an opaque struct pointer, thus there's no copy overhead I mentioned in my previous review.

The only concern I had that isn't addressed yet is the #if 0. I still would like to see this fixed in time, but it's not worth holding this merge up.

review: Approve

« Back to merge proposal