Code review comment for lp:~oif-team/frame/semi-mt-add-touches

Revision history for this message
Chase Douglas (chasedouglas) wrote :

> Thanks for the changes, some comments:
>
> * I would prefer clean patches before the changes on top.

This is really hard to do with bzr and is just not how it's meant to be used. I've gone with this approach because it's easiest for me and allows one to see how review responses are addressed in the merge request review.

> * The semantic change regarding id is fine per se, but needs a lot of thought
> and checks, because it is, indeed, an ABI break. I will have to get back to
> you on this one.

Is this completely resolved now, or are there any other issues?

> * The logic for number of fingers still seems to not handle the full range.

I believe they are handled appropriately now. The evdev semi-mt number of touches is only provided through BTN_TOOL_FINGER, BTN_TOOL_DOUBLETAP, BTN_TOOL_TRIPLETAP, and BTN_TOOL_QUADTAP. What else is there to add?

Thanks!

« Back to merge proposal