Code review comment for lp:~oif-team/frame/semi-mt-add-touches
Revision history for this message
| Chase Douglas (chasedouglas) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
I've added all the changes except for the tracking id value change. The issue is that the tracking IDs from utouch-frame don't have a boundary. If you're using the mtdev backend there is the range from the kernel, but this isn't exposed to the utouch-frame clients. As such, the only boundaries are that the tracking ID fits inside an int (32 bits) and is not equal to -1.
Henrik, how do you want to resolve this issue? Should we assume the valid tracking ID range is 0 to 2^32 - 2, 0 to 2^31 - 1 (all positive values of an int), or something else? I'll note that the XI 2.1 spec says it's an unsigned int that can take any value, if that's of any help in determining the best resolution here.