Code review comment for lp:~oif-team/frame/semi-mt-add-touches

Revision history for this message
Henrik Rydberg (rydberg) wrote :

I like the idea, just some comments on the implementation:

The EV_KEY code could be broken out into its own function, like for EV_ABS events.
Also, the number of active contacts needs to be set also for one touch, etc.

Reusing older touch ids could work, but note that the one chosen is likely to have been
used recently. Also, the tracking id range of the device should be respected. An alternative
is to pick an offset somewhere in the middle of the given tracking range.

review: Needs Fixing

« Back to merge proposal