Code review comment for lp:~ogra/xdiagnose/py3port

Revision history for this message
Bryce Harrington (bryce) wrote :

Excellent, thanks!

I sorted out the build issue I was seeing. It appears that the package build requires *both* python-distutils-extra and python3-distutils-extra. Not sure why, but unless both are included as build requirements, the package fails in the dh_auto_clean proc. I'm guessing that this is running clean for both python2 and python3, or something like that.

There's still a couple warnings I'm seeing:

   dh_python3 -O--buildsystem=python_distutils
W: dh_python3:181: Python 2.x location detected, please use dh_python2: debian/xdiagnose/usr/lib/python2.7
   dh_python2 -O--buildsystem=python_distutils
W: dh_python2:334: Python 3.x location detected, please use dh_python3: debian/xdiagnose/usr/lib/python3
   dh_usrlocal -O--buildsystem=python_distutils

However I think those are unrelated, and sound possibly innocuous so am going to ignore them for now. But if these sound meaningful to you, I'd love some tips on resolving them.

review: Approve

« Back to merge proposal