Code review comment for ~ogayot/ubuntu/+source/lomiri-download-manager:merge-lp2045635-noble

Thanks, Olivier.

Package-wise, everything LGTM. The package builds fine, which means that the build-time tests are passing. git range-diff is OK.

The only thing that's making me slightly uncomfortable is your patch :-). Not because I don't like, but because I'd rather see some feedback from upstream before you go ahead and ship it to our users. OTOH, I really like that you were thorough in the patch description, and also when submitting the patch to Debian *and* upstream. Thanks for that.

I will take my chances here and sponsor the upload for you, mostly because I know that, if upstream finds any issues with your patch, you will replicate the fixes here as well.

Thanks.

Uploaded:

$ dput lomiri-download-manager_0.1.2-2ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/lomiri-download-manager/lomiri-download-manager_0.1.2-2ubuntu1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/lomiri-download-manager/lomiri-download-manager_0.1.2-2ubuntu1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading lomiri-download-manager_0.1.2-2ubuntu1.dsc: done.
  Uploading lomiri-download-manager_0.1.2-2ubuntu1.debian.tar.xz: done.
  Uploading lomiri-download-manager_0.1.2-2ubuntu1_source.buildinfo: done.
  Uploading lomiri-download-manager_0.1.2-2ubuntu1_source.changes: done.
Successfully uploaded packages.