Merge ~ogayot/curtin:deb822-no-suite-stanza into curtin:master
Proposed by
Olivier Gayot
Status: | Merged |
---|---|
Approved by: | Dan Bungert |
Approved revision: | 29b3faf7c30eea08e5a955d9a9fbe3a32846e314 |
Merge reported by: | Server Team CI bot |
Merged at revision: | not available |
Proposed branch: | ~ogayot/curtin:deb822-no-suite-stanza |
Merge into: | curtin:master |
Diff against target: |
36 lines (+13/-1) 2 files modified
curtin/commands/apt_config.py (+5/-0) tests/unittests/test_apt_source.py (+8/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Server Team CI bot | continuous-integration | Approve | |
curtin developers | Pending | ||
Review via email: mp+450893@code.launchpad.net |
Commit message
apt_source: do not produce a deb822 source stanza with zero suite
When no suite is set for a given repository, we end up with a
deb822 styled source such as:
Type: deb
Suites:
URIs: http://
This is invalid and apt/apt-get will raise the following error:
E: Malformed entry 2 in sources file
/etc/apt/
Signed-off-by: Olivier Gayot <email address hidden>
Description of the change
Prevent creation of invalid deb822 source when no suite is configured.
To post a comment you must log in.
PASSED: Continuous integration, rev:d3b6443f3d3 4e1bd9ce4337b5b e3a495edd10a43 /jenkins. canonical. com/server- team/job/ curtin- ci/195/ /jenkins. canonical. com/server- team/job/ curtin- ci/nodes= metal-amd64/ 195/ /jenkins. canonical. com/server- team/job/ curtin- ci/nodes= metal-arm64/ 195/ /jenkins. canonical. com/server- team/job/ curtin- ci/nodes= metal-ppc64el/ 195/ /jenkins. canonical. com/server- team/job/ curtin- ci/nodes= metal-s390x/ 195/
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild: /jenkins. canonical. com/server- team/job/ curtin- ci/195/ /rebuild
https:/