> Thanks, this all looks reasonable.
An integration test would be nice - I think it should play out similar to test_gpt_uuid_persistent. WDYT?
Thanks! There was test_gpt_name_persistent that existed already. But since you asked, I've added a new test that covers more use-cases (accents + other unicode characters). Hope that's better.
> Off that was a bit of a brain-o on my part. As Dan says, an integration test would be nice.
Done!
NOTE: I'm reluctant to let the CI squash the 3 commits together. If you don't mind, let's merge using the merge guidelines rather than leaving that up to the CI. Thanks!
> Thanks, this all looks reasonable. uuid_persistent . WDYT?
An integration test would be nice - I think it should play out similar to test_gpt_
Thanks! There was test_gpt_ name_persistent that existed already. But since you asked, I've added a new test that covers more use-cases (accents + other unicode characters). Hope that's better.
> Off that was a bit of a brain-o on my part. As Dan says, an integration test would be nice.
Done!
NOTE: I'm reluctant to let the CI squash the 3 commits together. If you don't mind, let's merge using the merge guidelines rather than leaving that up to the CI. Thanks!