Code review comment for lp:~oerp.ca/account-financial-tools/add-bank-of-canada-rss

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Daniel, thank you very much for the contribution.

What worries me with this new source is that you are using feedparser library. This library is not detected on module install, and it will only fail if you select this source, causing the background process to fail. The alternative is to put this library as dependency, but maybe is to force user to install another library if they are not going to use this source.

What everybody thinks about this?

Regards.

review: Needs Fixing

« Back to merge proposal