Merge lp:~oem-qa/checkbox/patch_apport_interface_yesno into lp:checkbox

[Javier Collado]

ui_question_yesno method added to ApportInterface class

This method can be used both by hooks and symptom files. If any of them tries to call that method when reporting a bug from checkbox using apport, then a NotImplementedError exception will be raised and the bug won't be reported.

[lp:~oem-qa/checkbox/patch_apport_interface_yesno]

859. By Marc Tardif on 2010-11-25

Merged from cli_no_answer branch.

860. By Marc Tardif on 2010-11-29

Changed connection request back to use the full url instead rather than the path.

861. By Marc Tardif on 2010-12-08

Replaced external plugin with remote plugin in autotest and ltp scripts.

862. By Marc Tardif on 2010-12-10

Merged from testsprint-checkbox-base-sru-changes.

863. By Marc Tardif on 2010-12-23

Updated parsing of config parameters which fixes bug #689140.

864. By Marc Tardif on 2011-01-12

Merged from trunk.

865. By Marc Tardif on 2011-01-12

Merged from whitelist_file_comments_support.

866. By Marc Tardif on 2011-01-12

Fixed jobs_info plugin to strip commented lines in whitelist and blacklist files which might start with a space.

867. By Marc Tardif on 2011-01-12

Added additional logging to the reactor when firing messages.

868. By Marc Tardif on 2011-01-26

Merged from checkbox-add-pm-utils-requirement branch.

869. By Marc Tardif on 2011-01-27

Added support for TOUCH devices.

870. By Jeff Lane  on 2011-02-02

Merged cr3s fix for bug #561816

871. By Marc Tardif on 2011-02-02

Merged from bladernr to add _attachment suffix and lsmod attachment.

872. By Marc Tardif on 2011-02-02

Updated pot file.

873. By Marc Tardif on 2011-02-02

Fixed memory persistence to be rooted like file persistence.

874. By Marc Tardif on 2011-02-02

Fixed persist module to support not being given a filename.

875. By Marc Tardif on 2011-02-02

Extended persist_info plugin to answer to both begin and prompt-begin messages.

876. By Marc Tardif on 2011-02-03

Added support for Python 2.5 in checkbox.lib.transport.

877. By Marc Tardif on 2011-02-08

Merged from audio_test_failing branch.

878. By Marc Tardif on 2011-02-09

Merged from syslog branch.

879. By Marc Tardif on 2011-02-11

Added stop signal when executing messages.

880. By Marc Tardif on 2011-02-14

Migrated UI from libglade to gtkbuilder which fixes bug #403534.

881. By Marc Tardif on 2011-02-14

Defining default options in checkbox.application rather than CHECKBOX_OPTIONS environment variable.

882. By Marc Tardif on 2011-02-14

Added changelog entry for candidate revision.

883. By Marc Tardif on 2011-02-15

Merged from 719552.

884. By Marc Tardif on 2011-02-16

Changed description of nautilus_file_copy job which fixes bug #709688.

885. By Marc Tardif on 2011-02-18

Fixed title in progress dialog.

886. By Marc Tardif on 2011-02-25

Updated changelog with new upstream release.

887. By Marc Tardif on 2011-03-01

Updated pot file.

888. By Marc Tardif on 2011-03-01

Merged from 727411.

889. By Marc Tardif on 2011-03-11

Merged from 691241.

890. By Marc Tardif on 2011-03-11

Added support for trying to submit twice which fixes bug #531010.

891. By Marc Tardif on 2011-03-11

Merged from 642001.

892. By Jeff Lane  on 2011-03-11

Merged cli-cleanup for bug #221400

893. By Marc Tardif on 2011-03-14

Merged from checkbox-bug-fixes.

894. By Jeff Lane  on 2011-03-17

Land translation work by Mahyuddin Susanto via Michael Terry

895. By Jeff Lane  on 2011-03-17

Merged cr3 changes to changelog and control

896. By Marc Tardif on 2011-03-18

Added changelog entry for candidate revision.

897. By Jeff Lane  on 2011-03-29

Commited Gerhard Burgers punctuation fix for LP #744167

898. By Marc Tardif on 2011-03-29

Merged from 553777.

899. By Marc Tardif on 2011-03-29

Moved Gerhard Burger in changelog from 0.11.2 to 0.11.3.

900. By Marc Tardif on 2011-03-30

Fixed missing capital letter in sleep_state_test description.

901. By Marc Tardif on 2011-03-30

Merged from 744964.

902. By Jeff Lane  on 2011-04-05

Merged Marc Tardif fix for lp:729431

903. By Jeff Lane  on 2011-04-05

Merged Marc Tardif fixes to hibernate test for lp:630785

904. By Jeff Lane  on 2011-04-05

Merged addition of rtc test to sleep.txt.in to meet dependencies

905. By Marc Tardif on 2011-04-05

Reintroduced pm-utils requirements for jobs calling the sleep_test command and update po files.

906. By Marc Tardif on 2011-04-05

Merged checkbox log to apport report.

907. By Marc Tardif on 2011-04-05

Added changelog entry for candidate revision.

908. By Marc Tardif on 2011-04-18

Merged branch to enable camera detect test.

909. By Jeff Lane  on 2011-04-22

Merged Carl Milettes fix for lp:507943 (disk_bench_test hard coded drive)

910. By Marc Tardif on 2011-05-05

Fixed eval of resources with names like list item names.

911. By Marc Tardif on 2011-05-17

Merged from pygi-gtk3-port.

912. By Marc Tardif on 2011-05-17

Removed dead pixel test.

913. By Marc Tardif on 2011-05-19

Merged from 773667.

914. By Marc Tardif on 2011-05-24

Merged from 776734.

915. By Marc Tardif on 2011-05-25

Merged from 786924.

916. By Marc Tardif on 2011-05-25

Merged from 776712.

917. By Jeff Lane  on 2011-05-31

Applied Marc Tardifs changes to allow for remote submission (send results from a system other than the system under test)

918. By Marc Tardif on 2011-06-03

Merged from 588539.

919. By Marc Tardif on 2011-06-06

Merged from 665299.

920. By Marc Tardif on 2011-06-07

Wrapped submission stream to check for illegal xml characters.

[Daniel Manrique (roadmr)]

apport_prompt.py defines ApportUserInterface as a subclass of UserInterface. As per apport.ui.UserInterface documentation:

A concrete subclass must implement all the abstract ui_* methods.

While not all ui_* methods are actually implemented in ApportUserInterface, it's good to advance towards completion. This code basically does that. I checked that it doesn't interfere otherwise with Checkbox operations, and also that it merges cleanly against latest trunk (as of 2011-06-28). So I'd say this is OK to merge.

[Daniel Manrique (roadmr)]

Thanks Javier, looks good as per my previous comment, so merged.

review: Approve

=== modified file 'plugins/apport_prompt.py'
--- plugins/apport_prompt.py	2011-03-29 13:47:20 +0000
+++ plugins/apport_prompt.py	2011-06-08 14:26:12 +0000
@@ -135,6 +135,11 @@
 
         return [options.index(r) for r in results]
 
+    def ui_question_yesno(self, text):
+        self.interface.show_progress_stop()
+        result = self.interface.show_radio(text, ["Yes", "No"])
+        return result == "Yes"
+
     def open_url(self, url):
         self.interface.show_url(url)