Merge lp:~oem-qa/checkbox/patch_apport_add_test_info into lp:checkbox

[Javier Collado]

This change takes advantage of the recent fix to display again the 'Do you want to report a bug?' dialog to add the test case name and test suite (if available) that failed.

[lp:~oem-qa/checkbox/patch_apport_add_test_info]

842. By Marc Tardif on 2010-07-22

Firing report-job when reporting remote message.

843. By Marc Tardif <cr3@lime> on 2010-07-22

Moved makedir /var/cache/checkbox to root environment.

844. By Marc Tardif on 2010-07-24

Fixed typo in potfile to generate i18n strings for user_apps.txt.in.

845. By Marc Tardif on 2010-07-29

Merged from checkbox-pretty-report branch.

846. By Marc Tardif on 2010-08-13

Reduced size of some data files.

847. By Marc Tardif on 2010-08-13

Renamed a few more data files for consistency purposes.

848. By Marc Tardif on 2010-08-13

Updated changelog.

849. By Marc Tardif on 2010-08-13

Updated changelog again.

850. By Marc Tardif on 2010-08-18

Merged from fix-network-test branch.

851. By Marc Tardif on 2010-08-19

Replaced borrowed SWF file with another generated from source.

852. By Marc Tardif on 2010-08-19

Updated po files.

853. By Marc Tardif on 2010-09-14

Added verification of SSL validity which fixes bug #625076.

854. By Marc Tardif on 2010-09-14

Improved audio test questions.

855. By Marc Tardif on 2010-09-14

Added changelog entry for candidate revision.

856. By Marc Tardif on 2010-09-15

Updated pot file.

857. By Marc Tardif on 2010-09-15

Changed connection request to use the path rather than the full url.

858. By Marc Tardif on 2010-09-17

Increased version number

859. By Marc Tardif on 2010-11-25

Merged from cli_no_answer branch.

860. By Marc Tardif on 2010-11-29

Changed connection request back to use the full url instead rather than the path.

861. By Marc Tardif on 2010-12-08

Replaced external plugin with remote plugin in autotest and ltp scripts.

862. By Marc Tardif on 2010-12-10

Merged from testsprint-checkbox-base-sru-changes.

863. By Marc Tardif on 2010-12-23

Updated parsing of config parameters which fixes bug #689140.

864. By Marc Tardif on 2011-01-12

Merged from trunk.

865. By Marc Tardif on 2011-01-12

Merged from whitelist_file_comments_support.

866. By Marc Tardif on 2011-01-12

Fixed jobs_info plugin to strip commented lines in whitelist and blacklist files which might start with a space.

867. By Marc Tardif on 2011-01-12

Added additional logging to the reactor when firing messages.

868. By Marc Tardif on 2011-01-26

Merged from checkbox-add-pm-utils-requirement branch.

869. By Marc Tardif on 2011-01-27

Added support for TOUCH devices.

870. By Jeff Lane  on 2011-02-02

Merged cr3s fix for bug #561816

871. By Marc Tardif on 2011-02-02

Merged from bladernr to add _attachment suffix and lsmod attachment.

872. By Marc Tardif on 2011-02-02

Updated pot file.

873. By Marc Tardif on 2011-02-02

Fixed memory persistence to be rooted like file persistence.

874. By Marc Tardif on 2011-02-02

Fixed persist module to support not being given a filename.

875. By Marc Tardif on 2011-02-02

Extended persist_info plugin to answer to both begin and prompt-begin messages.

876. By Marc Tardif on 2011-02-03

Added support for Python 2.5 in checkbox.lib.transport.

877. By Marc Tardif on 2011-02-08

Merged from audio_test_failing branch.

878. By Marc Tardif on 2011-02-09

Merged from syslog branch.

879. By Marc Tardif on 2011-02-11

Added stop signal when executing messages.

880. By Marc Tardif on 2011-02-14

Migrated UI from libglade to gtkbuilder which fixes bug #403534.

881. By Marc Tardif on 2011-02-14

Defining default options in checkbox.application rather than CHECKBOX_OPTIONS environment variable.

882. By Marc Tardif on 2011-02-14

Added changelog entry for candidate revision.

883. By Marc Tardif on 2011-02-15

Merged from 719552.

884. By Marc Tardif on 2011-02-16

Changed description of nautilus_file_copy job which fixes bug #709688.

885. By Marc Tardif on 2011-02-18

Fixed title in progress dialog.

886. By Marc Tardif on 2011-02-25

Updated changelog with new upstream release.

887. By Marc Tardif on 2011-03-01

Updated pot file.

888. By Marc Tardif on 2011-03-01

Merged from 727411.

889. By Marc Tardif on 2011-03-11

Merged from 691241.

890. By Marc Tardif on 2011-03-11

Added support for trying to submit twice which fixes bug #531010.

891. By Marc Tardif on 2011-03-11

Merged from 642001.

892. By Jeff Lane  on 2011-03-11

Merged cli-cleanup for bug #221400

893. By Marc Tardif on 2011-03-14

Merged from checkbox-bug-fixes.

894. By Jeff Lane  on 2011-03-17

Land translation work by Mahyuddin Susanto via Michael Terry

895. By Jeff Lane  on 2011-03-17

Merged cr3 changes to changelog and control

896. By Marc Tardif on 2011-03-18

Added changelog entry for candidate revision.

897. By Jeff Lane  on 2011-03-29

Commited Gerhard Burgers punctuation fix for LP #744167

898. By Marc Tardif on 2011-03-29

Merged from 553777.

899. By Marc Tardif on 2011-03-29

Moved Gerhard Burger in changelog from 0.11.2 to 0.11.3.

900. By Marc Tardif on 2011-03-30

Fixed missing capital letter in sleep_state_test description.

901. By Marc Tardif on 2011-03-30

Merged from 744964.

902. By Jeff Lane  on 2011-04-05

Merged Marc Tardif fix for lp:729431

903. By Jeff Lane  on 2011-04-05

Merged Marc Tardif fixes to hibernate test for lp:630785

904. By Jeff Lane  on 2011-04-05

Merged addition of rtc test to sleep.txt.in to meet dependencies

905. By Marc Tardif on 2011-04-05

Reintroduced pm-utils requirements for jobs calling the sleep_test command and update po files.

906. By Marc Tardif on 2011-04-05

Merged checkbox log to apport report.

907. By Marc Tardif on 2011-04-05

Added changelog entry for candidate revision.

908. By Marc Tardif on 2011-04-18

Merged branch to enable camera detect test.

909. By Jeff Lane  on 2011-04-22

Merged Carl Milettes fix for lp:507943 (disk_bench_test hard coded drive)

910. By Marc Tardif on 2011-05-05

Fixed eval of resources with names like list item names.

911. By Marc Tardif on 2011-05-17

Merged from pygi-gtk3-port.

912. By Marc Tardif on 2011-05-17

Removed dead pixel test.

913. By Marc Tardif on 2011-05-19

Merged from 773667.

914. By Marc Tardif on 2011-05-24

Merged from 776734.

915. By Marc Tardif on 2011-05-25

Merged from 786924.

916. By Marc Tardif on 2011-05-25

Merged from 776712.

917. By Jeff Lane  on 2011-05-31

Applied Marc Tardifs changes to allow for remote submission (send results from a system other than the system under test)

918. By Marc Tardif on 2011-06-03

Merged from 588539.

919. By Marc Tardif on 2011-06-06

Merged from 665299.

920. By Marc Tardif on 2011-06-07

Wrapped submission stream to check for illegal xml characters.

[Marc Tardif (cr3)]

Merged Daniel's branch which implements the same functionality inspired by this branch:

https://code.launchpad.net/~roadmr/checkbox/improve_failed_test_message/+merge/66497

So, I'm disapproving this branch but the feature is good.

review: Disapprove

Unmerged revisions

=== modified file 'plugins/apport_prompt.py'
--- plugins/apport_prompt.py	2011-03-29 13:47:20 +0000
+++ plugins/apport_prompt.py	2011-06-08 14:21:34 +0000
@@ -216,8 +216,14 @@
         if not package and not symptom:
             return
 
-        response = interface.show_info(_("Do you want to report a bug?"),
-            ["yes", "no"], "no")
+        message = [_("Test case failed"),
+                   "- name: %s" % test["name"]]
+        if test.get("suite"):
+            message.append("- suite: %s" % test["suite"])
+        message.extend(["",
+                        _("Do you want to report a bug?")])
+        response = interface.show_info("\n".join(message),
+                                       ["yes", "no"], "no")
         if response == "no":
             return