PQM

Code review comment for lp:~oddbloke/pqm/merge-directives

Revision history for this message
Robert Collins (lifeless) wrote :

overall good.

A few issues:

 - uses more shell tests rather than python unit tests
 - the new Command class won't render correctly in the web GUI
 - I don't like the merge_callback lambda usage, its unobvious and doesn't seem necessary.

overall - resubmit

review: Disapprove

« Back to merge proposal