Code review comment for lp:~oddbloke/cloud-init/ssh-equals

Revision history for this message
Dan Watkins (oddbloke) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 13/11/14 09:44, Joshua Harlow wrote:
>> === modified file 'tests/unittests/test_sshutil.py' ---
>> tests/unittests/test_sshutil.py 2013-03-07 19:54:25 +0000 +++
>> tests/unittests/test_sshutil.py 2014-11-12 14:02:22 +0000 @@ -1,5
>> +1,8 @@ +from unittest import TestCase
>
> Can u use
> http://bazaar.launchpad.net/~cloud-init-dev/cloud-init/trunk/view/head:/tests/unittests/helpers.py#L37
> as the base class instead. This ensures that various functions that
> aren't on py26 actually work (or work good enough). Thanks.

Done and pushed.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJUZInfAAoJEO7mh3btsT6gZ10P/3i9a3OpwmQWwzVhuqLb8JLO
hS8OKWYIAT3bpMg9gsVDlY7i+65mxh62Yy6z/im6mlI1ZVggcVplZBjNJjYIbLFu
zzDRBh2OSMki4NNqSIv70m79FYyhNhP1hzibWD9yc2N2XmLc8rEz+DvK/ra5Q9FZ
f3n06YddpXgttVhyGtrAAeHMmki5215B4xfFTyLyK6WDnq7S+lke66M9AQxJBuMO
tvy9XtK0fPOH3G0XRo3Qh9IxqIciI/VEKLcTvaPIHZyF52RKB1QN8bvDWOZZ4aZ/
UPF+zDUbSGtbX26ASqpyB1opEXwf2n2gXaJqo+8XEczyyR8V5Rej7LlIhW+fpY7U
L1iOEUk7pF8wHFJBRPKDPy2jLclnR4wjt1WYujik8rPCgKTdaPUBQZsXNqW12iue
Pg9ZpuI8y8G5WnCx4UJGcp0jZ435oKb6B7Yb/9AhahhWZvGiYvLL7sZltxUQpz16
UN+Dv446YwnIZxxyVAzWaSJJKSuwYtFTAPH6Ekfw099IgR3WmqtMvedvw/Br+SZm
ePZ3R/Ncnb65pi3ZxYo6zQeNaKjwmXt5yulspVaXkRCLBp/LgMdzN0AGrrYaTWEn
JrRQs/mMHUj/NL9UHmghzRILQzA1uJFOOzJSwA0gEqL8TrcDIueff4YLZ5w79E60
KYYBDzrkLftL6ch8zZQA
=k8vE
-----END PGP SIGNATURE-----

« Back to merge proposal