Code review comment for ~oddbloke/cloud-init/+git/cloud-init:clean

Revision history for this message
Ryan Harper (raharper) wrote :

I manually applied your change to test_clean and it does trip the check that seed_dir is not removed.

======================================================================
FAIL: cloudinit.cmd.tests.test_clean.TestClean.test_remove_artifacts_removes_artifacts_skipping_seed
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/rharper/work/git/cloud-init/cloudinit/cmd/tests/test_clean.py", line 99, in test_remove_artifacts_removes_artifacts_skipping_seed
    'Missing {0} dir'.format(expected_dir))
AssertionError: False is not true : Missing /tmp/ci-TestClean.f5keq5q_/artifacts/seed dir
-------------------- >> begin captured logging << --------------------
cloudinit.util: DEBUG: Testing if a link exists for /tmp/ci-TestClean.f5keq5q_/artifacts/seed
cloudinit.util: DEBUG: Recursively deleting /tmp/ci-TestClean.f5keq5q_/artifacts/seed
cloudinit.util: DEBUG: Testing if a link exists for /tmp/ci-TestClean.f5keq5q_/artifacts/dir2
cloudinit.util: DEBUG: Recursively deleting /tmp/ci-TestClean.f5keq5q_/artifacts/dir2
cloudinit.util: DEBUG: Testing if a link exists for /tmp/ci-TestClean.f5keq5q_/artifacts/dir1
cloudinit.util: DEBUG: Recursively deleting /tmp/ci-TestClean.f5keq5q_/artifacts/dir1
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 8 tests in 0.012s

Approved if CI says yes as well.

review: Approve

« Back to merge proposal