I manually applied your change to test_clean and it does trip the check that seed_dir is not removed.
======================================================================
FAIL: cloudinit.cmd.tests.test_clean.TestClean.test_remove_artifacts_removes_artifacts_skipping_seed
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/rharper/work/git/cloud-init/cloudinit/cmd/tests/test_clean.py", line 99, in test_remove_artifacts_removes_artifacts_skipping_seed
'Missing {0} dir'.format(expected_dir))
AssertionError: False is not true : Missing /tmp/ci-TestClean.f5keq5q_/artifacts/seed dir
-------------------- >> begin captured logging << --------------------
cloudinit.util: DEBUG: Testing if a link exists for /tmp/ci-TestClean.f5keq5q_/artifacts/seed
cloudinit.util: DEBUG: Recursively deleting /tmp/ci-TestClean.f5keq5q_/artifacts/seed
cloudinit.util: DEBUG: Testing if a link exists for /tmp/ci-TestClean.f5keq5q_/artifacts/dir2
cloudinit.util: DEBUG: Recursively deleting /tmp/ci-TestClean.f5keq5q_/artifacts/dir2
cloudinit.util: DEBUG: Testing if a link exists for /tmp/ci-TestClean.f5keq5q_/artifacts/dir1
cloudinit.util: DEBUG: Recursively deleting /tmp/ci-TestClean.f5keq5q_/artifacts/dir1
--------------------- >> end captured logging << ---------------------
----------------------------------------------------------------------
Ran 8 tests in 0.012s
I manually applied your change to test_clean and it does trip the check that seed_dir is not removed.
======= ======= ======= ======= ======= ======= ======= ======= ======= ======= cmd.tests. test_clean. TestClean. test_remove_ artifacts_ removes_ artifacts_ skipping_ seed ------- ------- ------- ------- ------- ------- ------- ------- ------- rharper/ work/git/ cloud-init/ cloudinit/ cmd/tests/ test_clean. py", line 99, in test_remove_ artifacts_ removes_ artifacts_ skipping_ seed expected_ dir)) TestClean. f5keq5q_ /artifacts/ seed dir ------- ------ >> begin captured logging << ------- ------- ------ TestClean. f5keq5q_ /artifacts/ seed TestClean. f5keq5q_ /artifacts/ seed TestClean. f5keq5q_ /artifacts/ dir2 TestClean. f5keq5q_ /artifacts/ dir2 TestClean. f5keq5q_ /artifacts/ dir1 TestClean. f5keq5q_ /artifacts/ dir1 ------- ------- >> end captured logging << ------- ------- -------
FAIL: cloudinit.
-------
Traceback (most recent call last):
File "/home/
'Missing {0} dir'.format(
AssertionError: False is not true : Missing /tmp/ci-
-------
cloudinit.util: DEBUG: Testing if a link exists for /tmp/ci-
cloudinit.util: DEBUG: Recursively deleting /tmp/ci-
cloudinit.util: DEBUG: Testing if a link exists for /tmp/ci-
cloudinit.util: DEBUG: Recursively deleting /tmp/ci-
cloudinit.util: DEBUG: Testing if a link exists for /tmp/ci-
cloudinit.util: DEBUG: Recursively deleting /tmp/ci-
-------
------- ------- ------- ------- ------- ------- ------- ------- ------- -------
Ran 8 tests in 0.012s
Approved if CI says yes as well.