Code review comment for lp:~oddbloke/charms/trusty/ubuntu-repository-cache/error-message-fix

Revision history for this message
Charles Butler (lazypower) wrote :

Greetings Daniel,

Thank you for the contribution to the ubuntu-repository-cache charm. I've encountered some issues with the proposed fix here that goes beyond the timeout listed above.

It appears with revision 212, the branch in lp:~charmers/charms/trusty/ubuntu-repository-cache/trunk was broken. It will require an additional re-sync of charm-helpers to fix the python3 inconsistency of modules the charm expects to be installed.

Additionally, it appears the lp:~charmers/charms/trusty/ubuntu-repository-cache/trunk branch is no longer the primary point of development, and this should instead be directed at:

lp:~cloudware/charms/trusty/ubuntu-repository-cache/trunk

With these concerns outlined, I regret to inform you that I am unable to accept this merge as is, and would advise you to re-submit against the upstream charm, in lp:~cloudware

Thanks again for your contribution, and I look forward to reviewing/landing this contribution in the proper places.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.

review: Needs Resubmitting

« Back to merge proposal