Merge lp:~ochosi/ubiquity/partition_spinbutton into lp:ubiquity

[Simon Steinbeiß]

This (dead-simple) patch is aimed at resolving this bug: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1622258

The gist is that the current width of the partition_size_spinbutton widget in Ubiquity's stepPartAdvanced.ui is set to 6 characters, which is barely enough for displaying GB values in MB. If people have larger drives they will always have to scroll, which may lead to errors and is generally tedious in such a small input box.

I consequently suggest bumping the width_chars value from 6 to 10 (Petabyte) and setting the "hexpand" option, which means the spinbutton will occupy all remaining horizontal space.

[Simon Steinbeiß (ochosi)]

Note that this also restores what we saw in 16.04 (i.e. the spinbutton expanding horizontally).

[Mathieu Trudel-Lapierre (cyphermox)]

review: Approve

=== modified file 'gui/gtk/stepPartAdvanced.ui'
--- gui/gtk/stepPartAdvanced.ui	2014-03-13 06:23:07 +0000
+++ gui/gtk/stepPartAdvanced.ui	2016-09-12 21:45:37 +0000
@@ -193,7 +193,8 @@
                     <property name="can_focus">True</property>
                     <property name="invisible_char">●</property>
                     <property name="activates_default">True</property>
-                    <property name="width_chars">6</property>
+                    <property name="hexpand">True</property>
+                    <property name="width_chars">10</property>
                     <property name="xalign">1</property>
                     <property name="invisible_char_set">True</property>
                     <property name="primary_icon_activatable">False</property>