Code review comment for lp:~nurlan0000/psiphon/sprint3-610191

Revision history for this message
Adam P (adam+) wrote :

Sorry for the delay -- I didn't notice the email where you had checked in more changes.

There are some problems with the your user_groups.html test case. The login stuff uses hardcoded proxy info, which won't work on all machines, and hardcoded user stuff, which you haven't added to test_init.php and so doesn't work at all (except on your machine).

--- Login/Logout/Include ---

To log in, you should include login.html -- see bookmarks.html and login_delay.html for examples. You can specify what username and password should be used like this:
<tr>
  <td>include</td>
  <td>/selenium_scripts/login.html</td>
  <td>current_username=username,current_password=password</td>
</tr>
For more info, see: wiki.openqa.org/display/SEL/include

To logout, you should use this:
<tr>
  <td>include</td>
  <td>/selenium_scripts/logout.html</td>
  <td></td>
</tr>

--- Test users ---

If you need particular users to exist during your test, you should either create them using Selenium (using invitations or the Admin Users screen) or insert them directly into the database in test_init.php (you can see user 'seleniumadmin' being inserted there now).

---

Since I wasn't able to run the test at all, I don't know if there are other issues.

review: Needs Fixing

« Back to merge proposal