OpenERP Community Backports (Addons)

Code review comment for lp:~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls

  1. 7.0-revert-sale-properties-1291903-ls
  2. Merge into 7.0
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Great, thanks for picking this up!

Quite a history this one has in upstream OpenERP:
- Initial fix committed as http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/9172,
- reverted in http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/9175, presumably because it breaks tests like it backport did in OCB.
- The next commit moves the fix to a method override on the wrong model: http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/9176
- http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/9378 reintroduces the original fix
- http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/9622 removes the original fix again because it breaks tests
- http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/9741 moves the fix to the correct method override on sale.order model but in a module that does not depend on sale
- http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/9751 correctly moves the method override to sale_mrp

For my review, I verified that OCB still propagates the properties with this change.

review: Approve (test, code review)

« Back to merge proposal