Code review comment for lp:~nuclearbob/utah/vm-teardown-fix

Revision history for this message
Max Brustkern (nuclearbob) wrote :

activecheck and _start shouldn't really be concerned with provisioning. activecheck runs provisioncheck, so if the machine isn't provisioned properly, something else should raise an exception. Just in case we somehow get past that, activecheck and start will now raise exceptions if self.vm isn't defined. Other than that, their behavior should be somewhat simpler, mostly assuming that provisioncheck either does its job or raises an exception.

This is some of the first code I wrote for UTAH, and I think I've learned a lot since then. Let me know what you think of the new changes. I've also merged the latest stuff from the dev branch.

review: Needs Resubmitting

« Back to merge proposal