Merge lp:~nuclearbob/utah/parser-packaging into lp:utah

Proposed by Max Brustkern
Status: Merged
Approved by: Joe Talbott
Approved revision: 762
Merged at revision: 765
Proposed branch: lp:~nuclearbob/utah/parser-packaging
Merge into: lp:utah
Diff against target: 68 lines (+18/-3)
2 files modified
debian/control (+8/-2)
debian/rules (+10/-1)
To merge this branch: bzr merge lp:~nuclearbob/utah/parser-packaging
Reviewer Review Type Date Requested Status
Joe Talbott (community) Approve
Review via email: mp+137212@code.launchpad.net

Description of the change

This change adds a utah-common package that contains the python module egg and __init__.py. utah-client and utah-parser both depend on the common package, so they can both get __init__.py without conflicting.

To post a comment you must log in.
Revision history for this message
Joe Talbott (joetalbott) wrote :

Looks good. Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2012-11-29 15:31:48 +0000
+++ debian/control 2012-11-30 14:33:34 +0000
@@ -25,14 +25,20 @@
25Package: utah-client25Package: utah-client
26Architecture: all26Architecture: all
27Depends: ${misc:Depends}, ${python:Depends},27Depends: ${misc:Depends}, ${python:Depends},
28 bzr, python-jsonschema (>= 0.5~), python-yaml28 bzr, python-jsonschema (>= 0.5~), python-yaml, utah-common
29Recommends: git29Recommends: git
30Description: Ubuntu Test Automation Harness Client30Description: Ubuntu Test Automation Harness Client
31 Automation framework for testing in Ubuntu, client portion31 Automation framework for testing in Ubuntu, client portion
32
33Package: utah-common
34Architecture: all
35Depends: ${misc:Depends}, ${python:Depends}
36Description: Ubuntu Test Automation Harness Common Files
37 Automation framework for testing in Ubuntu, common files
32 38
33Package: utah-parser39Package: utah-parser
34Architecture: all40Architecture: all
35Depends: ${misc:Depends}, ${python:Depends},41Depends: ${misc:Depends}, ${python:Depends},
36 python-jsonschema (>= 0.5~), python-yaml42 python-jsonschema (>= 0.5~), python-yaml, utah-common
37Description: Ubuntu Test Automation Harness Parser43Description: Ubuntu Test Automation Harness Parser
38 Automation framework for testing in Ubuntu, result parser44 Automation framework for testing in Ubuntu, result parser
3945
=== modified file 'debian/rules'
--- debian/rules 2012-11-29 15:31:48 +0000
+++ debian/rules 2012-11-30 14:33:34 +0000
@@ -21,13 +21,16 @@
21 # utah-parser lives in that tree as well21 # utah-parser lives in that tree as well
22 # utah should only install the provisioning subdirectory, and utah-client should install everything else22 # utah should only install the provisioning subdirectory, and utah-client should install everything else
23 # except parser.py, which is now its own package23 # except parser.py, which is now its own package
24 # If we just use dh_auto_install, both packages will get everything24 # and __init__.py, which is now in the common package
25 # If we just use dh_auto_install, all packages will get everything
25 # We start by building the whole thing26 # We start by building the whole thing
26 set -e && for pyvers in $(PYVERS); do python$$pyvers setup.py install --install-layout=deb --root=$(CURDIR); done27 set -e && for pyvers in $(PYVERS); do python$$pyvers setup.py install --install-layout=deb --root=$(CURDIR); done
27 # Next, we move the built provisioning directory aside for later use28 # Next, we move the built provisioning directory aside for later use
28 mv build/*/utah/provisioning .29 mv build/*/utah/provisioning .
29 # Same with parser.py30 # Same with parser.py
30 mv build/*/utah/parser.py .31 mv build/*/utah/parser.py .
32 # And __init__.py
33 mv build/*/utah/__init__.py .
31 # Now we install into the utah-client directory, since provisioning is removed, using --skip-build to not rebuild it34 # Now we install into the utah-client directory, since provisioning is removed, using --skip-build to not rebuild it
32 set -e && for pyvers in $(PYVERS); do python$$pyvers setup.py install --skip-build --install-layout=deb --root=$(CURDIR)/debian/utah-client; done35 set -e && for pyvers in $(PYVERS); do python$$pyvers setup.py install --skip-build --install-layout=deb --root=$(CURDIR)/debian/utah-client; done
33 # Now we remove everything we don't want in the utah package (i.e., everything that's still there)36 # Now we remove everything we don't want in the utah package (i.e., everything that's still there)
@@ -40,6 +43,10 @@
40 rm -r build/*/utah/*43 rm -r build/*/utah/*
41 mv parser.py build/*/utah44 mv parser.py build/*/utah
42 set -e && for pyvers in $(PYVERS); do python$$pyvers setup.py install --skip-build --install-layout=deb --root=$(CURDIR)/debian/utah-parser; done45 set -e && for pyvers in $(PYVERS); do python$$pyvers setup.py install --skip-build --install-layout=deb --root=$(CURDIR)/debian/utah-parser; done
46 # And now we put back the init file and install that
47 rm -r build/*/utah/*
48 mv __init__.py build/*/utah
49 set -e && for pyvers in $(PYVERS); do python$$pyvers setup.py install --skip-build --install-layout=deb --root=$(CURDIR)/debian/utah-common; done
43 # Since the client changes names from client.py to utah, we can't use utah-client.install for that50 # Since the client changes names from client.py to utah, we can't use utah-client.install for that
44 # We also need to make our directory since we do this before dh_auto_install51 # We also need to make our directory since we do this before dh_auto_install
45 mkdir -p $(CURDIR)/debian/utah-client/usr/bin52 mkdir -p $(CURDIR)/debian/utah-client/usr/bin
@@ -51,6 +58,8 @@
51 rm -r $(CURDIR)/debian/utah-client/usr/lib/python*/dist-packages/utah-*.egg-info58 rm -r $(CURDIR)/debian/utah-client/usr/lib/python*/dist-packages/utah-*.egg-info
52 # Let's remove it from the parser as well59 # Let's remove it from the parser as well
53 rm -r $(CURDIR)/debian/utah-parser/usr/lib/python*/dist-packages/utah-*.egg-info60 rm -r $(CURDIR)/debian/utah-parser/usr/lib/python*/dist-packages/utah-*.egg-info
61 # We'll remove it from the server and leave it in the client package
62 rm -r $(CURDIR)/debian/utah/usr/lib/python*/dist-packages/utah-*.egg-info
54 # We want to symlink the utah example scripts into /usr/bin, and we need a directory for that63 # We want to symlink the utah example scripts into /usr/bin, and we need a directory for that
55 mkdir -p $(CURDIR)/debian/utah/usr/bin64 mkdir -p $(CURDIR)/debian/utah/usr/bin
56 for script in $$(find examples -type f -name "*.py" -printf "%f\n"); do\65 for script in $$(find examples -type f -name "*.py" -printf "%f\n"); do\

Subscribers

People subscribed via source and target branches