Code review comment for lp:~nuclearbob/utah/docstring-cleanup

Revision history for this message
Max Brustkern (nuclearbob) wrote :

I've fixed all but one of the client test issues. I'm still not raising MissingData, because we decided in the code review to take out the block of code that raises that. I think some other exception should be raised, however, and that doesn't appear to be happening. I think the lack of another exception is not a problem with this merge, but we should either fix that problem, or reinstate the MissingData block before moving forward. I'm in favor of fixing the problem, so I'm going to try for that.

« Back to merge proposal