Code review comment for lp:~nuclearbob/utah/config-changes

Revision history for this message
Joe Talbott (joetalbott) wrote :

Looks good to me.

One nit; I'd put the release choices into a module level variable somewhere so you only have to make the change in one place.

in common.py

SERIES_CHOICES = ['hardy', 'lucid', ..., 'raring']

and in the other places

from common import SERIES_CHOICES
...
parser.add_argument(..., choices=SERIES_CHOICES...

and

vm_release_list = " ".join(SERIES_CHOICES)

review: Approve

« Back to merge proposal