Code review comment for lp:~nuclearbob/utah/cobbler-pidlock

Revision history for this message
Javier Collado (javier.collado) wrote :

@Max

I think this looks like two different columns are needed. One for the state
and one for the pid and that the pid is used to check if the state can be trusted.
Encoding both things in one column could lead to confusion.

Another improvement could be to have a new table named states with all the possible
states as strings and replace the state column in the machines with state_id to be
used as a foreign key.

Finally, I'm not sure if this will grow in complexity in the future, but have you
thought about using an ORM instead of write sql commands directly?

« Back to merge proposal