Code review comment for lp:~nuclearbob/utah/cobbler-pidlock

Revision history for this message
Joe Talbott (joetalbott) wrote :

On Thu, Oct 11, 2012 at 01:24:20PM -0000, Max Brustkern wrote:
> I updated the check to look for "utah" or "run_test_cobbler.py" on the command line. I'm testing now. The thing about changing the name of the field is that it still could be "available" which isn't a pid. What's a good name that indicates it can either be a state or a pid? Or can we change available to some number that will never be a pid, like -1?

What about changing the value to 'available - <pid>'? Then you can string
compare on 'available' and easily parse out the pid for doing the check.
> --
> https://code.launchpad.net/~nuclearbob/utah/cobbler-pidlock/+merge/129046
> Your team UTAH Dev is requested to review the proposed merge of lp:~nuclearbob/utah/cobbler-pidlock into lp:utah.

« Back to merge proposal