Code review comment for lp:~nuclearbob/utah/bug1155615

Revision history for this message
Andy Doan (doanac) wrote :

On 04/26/2013 02:18 PM, Max Brustkern wrote:
> As far as os.path.join is concerned, I don't think we actually need it in the vast majority of cases we're currently using it, but it always seems like a good idea? If we want to use that less, I'd like to be clearer on when we do and don't want to use it.

yeah - this isn't the only place. I guess I see it as useful when you
are joining variables like "basedir" and "fname". ie
  os.path.join(basedir, fname)

but maybe that's beyond the scope of this.

« Back to merge proposal