Merge lp:~nuclearbob/utah/bug1047366 into lp:utah

[Max Brustkern]

This branch checks the return code of cobbler commands. If the return code is nonzero, an error will be logged and an exception will be raised. Cobbler often exits with status 0 when a failure has occurred, but this should catch some issues.

[Joe Talbott (joetalbott)]

Looks good to me.

review: Approve

=== modified file 'utah/provisioning/baremetal/cobbler.py'
--- utah/provisioning/baremetal/cobbler.py	2012-08-30 08:34:34 +0000
+++ utah/provisioning/baremetal/cobbler.py	2012-09-19 19:05:34 +0000
@@ -172,7 +172,9 @@
         Pull out all cobbler commands so that we can later support changing
         users, remote login, not sudo, etc.
         """
-        self._runargs(['sudo', 'cobbler'] + cmd)
+        if self._runargs(['sudo', 'cobbler'] + cmd) != 0:
+            self.logger.error('Cobbler command failed: ' + ' '.join(cmd))
+            raise UTAHBMProvisioningException('Cobbler command failed: ' + ' '.join(cmd))
 
     def _start(self):
         """