Code review comment for lp:~nttdata/nova/live-migration

Revision history for this message
Vish Ishaya (vishvananda) wrote :

Looking good. Three minor points:

143 - instance_id = floating_ip_ref['fixed_ip']['instance']['ec2_id']
144 + # modified by masumotok
145 + #instance_id = floating_ip_ref['fixed_ip']['instance']['ec2_id']
146 + instance_id = floating_ip_ref['fixed_ip']['instance']['id']

This is a bug and your change is correct, you can remove the comments.

1236
1237 - logging.info('ensuring static filters')
1238 self._ensure_static_filters()
1239

I assume you did this during debugging. You should probably add it back in.

Finally, two new drivers were added to volume/driver.py. Since discover_volume has been modified to take a context parameter, please add _context to the other two volume types as well.

« Back to merge proposal