Code review comment for lp:~nttdata/nova/live-migration

2011/1/11 Kei Masumoto <email address hidden>:
> You mentioned "'launched_on':self.host" should be removed didn't you?
> Before doing so, let me explain.
>
> "host' column on Instance table is to record which host an instance is
> running on. Therefore, values are updated if an instance is moved by
> live migration. On the other hand, 'launched_on' column that I
> created is to record which host an instance was launched, and is not
> updated. This information is necessary because cpuflag of launched
> host must have compatibility to the one of live migration destination
> host. For this reason, I insert save value twice to different column
> when an instance is launched.

That makes perfect sense. I somehow thought you were passing it twice in
an RPC call. Please ignore that part of my review, then :)

--
Soren Hansen <email address hidden>
Systems Architect, The Rackspace Cloud
Ubuntu Developer