Code review comment for lp:~nttdata/nova/kvm-pause-suspend

Revision history for this message
Kei Masumoto (masumotok) wrote :

Hi, thanks for review!

> Also, if there is a specific case you're trying to handle, can you please
> add a comment to the code so that everyone knows what it is.
Before I wrote some comments in source code, let me explain.

I have encountered situations that /etc/libvirt/qemu/instance-<id>.xml was erased by admin's mistakes after suspending instance( or anytime when instances have problem). Then just calling dom.create() doen't work(raise exception). I know that situation is not normally happens, so that error handling isn't inevitable and not essential. But few line of error handling code don’t disturb anything.

Can I add exception handling and comments, or should I erase all error handling here?

« Back to merge proposal