Code review comment for lp:~ntt-pf-lab/nova/lp703037

Revision history for this message
Vish Ishaya (vishvananda) wrote :

I notice that you are using project_get_network to get the ra server for the project. This will not work properly in flatDHCP mode which doesn't have the project set. This needs to be changed to db.network_get_by_instance. I also noticed there are a few other references to this method that need to be changed, so I've put in an additional bug and fix here:

https://code.launchpad.net/~vishvananda/nova/lp707262

 so you might want to merge that branch as well and propose with that branch as a prerequisite

review: Needs Fixing

« Back to merge proposal