Code review comment for lp:~nskaggs/ubuntu-ui-toolkit/fix-aphelper-emulator-warning

Revision history for this message
Leo Arias (elopio) wrote :

balloons, your test_import_toolkit_must_not_log_warning is wrong because after patching the log you are not trying to import the module. So the log will always be empty.
I tried to re-import ubuntuuitoolkit, but none of the tricks I have used before worked in this case. Maybe we can get a hand from thomi, barry or mfoord, unless you have a better idea than the ones I tried.

Thanks.

« Back to merge proposal