Code review comment for lp:~nskaggs/ubuntu-terminal-app/fix-circle-test

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

hm, ok wait_select_single() changes are ok, so +1 on those. Not sure about line 77.
This will fix the test but it *might* theoretically make this test broken in certain cases, like when the phone is in landscape orientation. Then the first press is done in the middle of the screen, the OSK pops up, takes up half of the screen and the longpress is not registered (because the press happens on the OSK).

review: Needs Fixing

« Back to merge proposal