Merge lp:~nskaggs/ubuntu-filemanager-app/fix-armhf-build into lp:ubuntu-filemanager-app

Proposed by Nicholas Skaggs
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 145
Merged at revision: 148
Proposed branch: lp:~nskaggs/ubuntu-filemanager-app/fix-armhf-build
Merge into: lp:ubuntu-filemanager-app
Diff against target: 38 lines (+5/-4)
1 file modified
CMakeLists.txt (+5/-4)
To merge this branch: bzr merge lp:~nskaggs/ubuntu-filemanager-app/fix-armhf-build
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Dimitri John Ledkov Pending
Ubuntu File Manager Developers Pending
Review via email: mp+211621@code.launchpad.net

Commit message

Get cmake building properly

Description of the change

Get cmake building properly

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Still need to include the plugin as part of the build so the resulting click package is sound.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Merging everything, minus the plugin as it will be delayed.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2014-02-19 00:00:15 +0000
+++ CMakeLists.txt 2014-03-26 14:25:58 +0000
@@ -12,7 +12,7 @@
12set(URLS_FILE "${PROJECT_NAME}_${APP_NAME}.url-dispatcher")12set(URLS_FILE "${PROJECT_NAME}_${APP_NAME}.url-dispatcher")
13set(APP_HARDCODE ubuntu-filemanager-app)13set(APP_HARDCODE ubuntu-filemanager-app)
14set(MAIN_QML ${APP_HARDCODE}.qml)14set(MAIN_QML ${APP_HARDCODE}.qml)
15set(ICON filemanager64.png)15set(ICON_FILE filemanager64.png)
16set(AUTOPILOT_DIR ubuntu_filemanager_app)16set(AUTOPILOT_DIR ubuntu_filemanager_app)
1717
18if(CLICK_MODE)18if(CLICK_MODE)
@@ -23,13 +23,14 @@
23 set(CMAKE_INSTALL_PREFIX /)23 set(CMAKE_INSTALL_PREFIX /)
24 set(CMAKE_INSTALL_BINDIR /)24 set(CMAKE_INSTALL_BINDIR /)
25 set(DATA_DIR /)25 set(DATA_DIR /)
26 set(EXEC "qmlscene ${MAIN_QML}")26 set(ICON ${ICON_FILE})
27 set(EXEC "qmlscene -qt5 ${MAIN_QML}")
27 set(DESKTOP_DIR ${DATA_DIR})28 set(DESKTOP_DIR ${DATA_DIR})
28 set(URLS_DIR ${DATA_DIR})29 set(URLS_DIR ${DATA_DIR})
29else(CLICK_MODE)30else(CLICK_MODE)
30 set(DATA_DIR ${CMAKE_INSTALL_DATADIR}/${APP_HARDCODE})31 set(DATA_DIR ${CMAKE_INSTALL_DATADIR}/${APP_HARDCODE})
31 set(EXEC ${APP_HARDCODE})32 set(EXEC ${APP_HARDCODE})
32 set(ICON ${CMAKE_INSTALL_PREFIX}/${DATA_DIR}/${ICON})33 set(ICON ${CMAKE_INSTALL_PREFIX}/${DATA_DIR}/${ICON_FILE})
33 configure_file(${APP_HARDCODE}.in34 configure_file(${APP_HARDCODE}.in
34 ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE})35 ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE})
35 install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE}36 install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE}
@@ -49,7 +50,7 @@
49 *.qml *.js *.png *.js *.json)50 *.qml *.js *.png *.js *.json)
50install(DIRECTORY ui components icons51install(DIRECTORY ui components icons
51 DESTINATION ${DATA_DIR})52 DESTINATION ${DATA_DIR})
52install(FILES ${MAIN_QML} DESTINATION ${DATA_DIR})53install(FILES ${SRC_FILES} ${ICON_FILE} DESTINATION ${DATA_DIR})
5354
54configure_file(${DESKTOP_FILE}.in ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE})55configure_file(${DESKTOP_FILE}.in ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE})
55install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}56install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}

Subscribers

People subscribed via source and target branches