Code review comment for lp:~nskaggs/ubuntu-clock-app/switch-emulators-to-proxy-object

> What we are doing actually is to put most of the things that were on
> ubuntu_clock_app/emulators.py into ubutu_clock_app/__init__.py.
> If it grows to big, I started moving some of the objects into
> ubuntu_clock_app/pages/name_of_the_page.py
>
Thanks for writing that out. I was fumbling over words trying to explain that the emulators.py file more or less is legacy, so a name isn't really worth worrying about. Though we need one until we move things ;)
> 173 - # TODO: This wait to ensure that the textfield is visible before
> 174 - # entering text should be part of the SDK emulator. Until then, it
> has
> 175 - # been added here. http://pad.lv/1289616 --nik90 2014-03-06
> 176 - name_alarm.visible.wait_for(True)
>
> On the text field helper, we are waiting for it to be focused, not to be
> visible. I left a comment on that bug saying that now I think it's the caller
> who should wait for the UI to be ready to receive input.
> But anyway, I have done nothing yet to remove this wait. If it's no longer
> needed, then it's because the clock UI changed, not because the bug is fixed.
When I check the helper, it indeed showed you are waiting for the object to be focused; but inherently if it's focused it's writeable. I guess we can argue semantics about being visible. The point is, if it's focused it's ready to receive input which is what we need. Visible lies anyway, so if you are wanting to know if the item is onscreen and visible, that's really for the test writer I agree.