Merge lp:~nskaggs/ubuntu-calendar-app/addingWaitTime into lp:ubuntu-calendar-app

[Nicholas Skaggs]

Adding wait time to Event Page & Delete Confirmation to prevent AP fails.

Adding wait time to Event Page & Delete Confirmation to prevent AP fails.

[Nicholas Skaggs (nskaggs)]

<balloons> mihir_, I would add root.wait_select_single(DayView, objectName='dayViewPage') in as well in the delete method
<balloons> hmm
<balloons> mihir_, also, return root.select_single(NewEvent, objectName='newEventPage') to a wait
<balloons> that's in edit ^^

In addition, I would add a wait to

        return self.get_root_instance().select_single(
            EventDetails, objectName='eventDetails')

review: Needs Fixing

[Nicholas Skaggs (nskaggs)]

Just finishing this for mihir.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/addingWaitTime/+merge/236602/+edit-commit-message

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:486
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/881/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/620/console
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/439

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/881/rebuild

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:487
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/882/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/621
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/621/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/440

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/882/rebuild

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/377/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/622
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/622/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-autolanding/197

review: Needs Fixing (continuous-integration)

[lp:~nskaggs/ubuntu-calendar-app/addingWaitTime]

488. By Nicholas Skaggs on 2014-09-30

fix wait selects

[Mihir Soni (mihirsoni)]

Looks good to me
Thanks Balloons :)

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'tests/autopilot/calendar_app/__init__.py'
--- tests/autopilot/calendar_app/__init__.py	2014-09-23 15:09:07 +0000
+++ tests/autopilot/calendar_app/__init__.py	2014-09-30 20:55:49 +0000
@@ -123,7 +123,7 @@
         """
         header = self.get_header()
         header.click_action_button('neweventbutton')
-        return self.select_single(NewEvent, objectName='newEventPage')
+        return self.wait_select_single(NewEvent, objectName='newEventPage')
 
     def set_picker(self, field, mode, value):
         # open picker
@@ -491,7 +491,7 @@
         center_y = self.globalRect.y + self.globalRect.height // 2
         self.pointing_device.move(left, center_y)
         self.pointing_device.click()
-        return self.get_root_instance().select_single(
+        return self.get_root_instance().wait_select_single(
             EventDetails, objectName='eventDetails')
 
 
@@ -654,11 +654,11 @@
         header = root.select_single(MainView).get_header()
         header.click_action_button('delete')
 
-        delete_confirmation_dialog = root.select_single(
+        delete_confirmation_dialog = root.wait_select_single(
             DeleteConfirmationDialog, objectName='deleteConfirmationDialog')
         delete_confirmation_dialog.confirm_deletion()
 
-        return root.select_single(DayView, objectName='dayViewPage')
+        return root.wait_select_single(DayView, objectName='dayViewPage')
 
     @autopilot.logging.log_action(logger.debug)
     def edit(self):
@@ -670,7 +670,7 @@
         root = self.get_root_instance()
         header = root.select_single(MainView).get_header()
         header.click_action_button('edit')
-        return root.select_single(NewEvent, objectName='newEventPage')
+        return root.wait_select_single(NewEvent, objectName='newEventPage')
 
     def get_event_information(self):
         """Return the information of the event."""