Merge lp:~mihirsoni/ubuntu-calendar-app/addingWaitTime into lp:ubuntu-calendar-app

Proposed by Mihir Soni
Status: Superseded
Proposed branch: lp:~mihirsoni/ubuntu-calendar-app/addingWaitTime
Merge into: lp:ubuntu-calendar-app
Diff against target: 20 lines (+2/-2)
1 file modified
tests/autopilot/calendar_app/__init__.py (+2/-2)
To merge this branch: bzr merge lp:~mihirsoni/ubuntu-calendar-app/addingWaitTime
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Nicholas Skaggs (community) Needs Fixing
Review via email: mp+236598@code.launchpad.net

This proposal has been superseded by a proposal from 2014-09-30.

Commit message

Adding wait time to Event Page & Delete Confirmation to prevent AP fails.

Description of the change

Adding wait time to Event Page & Delete Confirmation to prevent AP fails.

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

<balloons> mihir_, I would add root.wait_select_single(DayView, objectName='dayViewPage') in as well in the delete method
<balloons> hmm
<balloons> mihir_, also, return root.select_single(NewEvent, objectName='newEventPage') to a wait
<balloons> that's in edit ^^

In addition, I would add a wait to

        return self.get_root_instance().select_single(
            EventDetails, objectName='eventDetails')

review: Needs Fixing
487. By Mihir Soni

adding wait time in event details/weekview/dayview

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

487. By Mihir Soni

adding wait time in event details/weekview/dayview

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/calendar_app/__init__.py'
2--- tests/autopilot/calendar_app/__init__.py 2014-09-23 15:09:07 +0000
3+++ tests/autopilot/calendar_app/__init__.py 2014-09-30 19:55:01 +0000
4@@ -123,7 +123,7 @@
5 """
6 header = self.get_header()
7 header.click_action_button('neweventbutton')
8- return self.select_single(NewEvent, objectName='newEventPage')
9+ return self.wait_single(NewEvent, objectName='newEventPage')
10
11 def set_picker(self, field, mode, value):
12 # open picker
13@@ -654,7 +654,7 @@
14 header = root.select_single(MainView).get_header()
15 header.click_action_button('delete')
16
17- delete_confirmation_dialog = root.select_single(
18+ delete_confirmation_dialog = root.wait_single(
19 DeleteConfirmationDialog, objectName='deleteConfirmationDialog')
20 delete_confirmation_dialog.confirm_deletion()
21

Subscribers

People subscribed via source and target branches

to status/vote changes: