Code review comment for lp:~nskaggs/music-app/fix-shuffle-test

Revision history for this message
Victor Thompson (vthompson) wrote :

The test_next_previous looks good. I'm not so sure with the test_mp3 1) maybe ensure shuffle is off outside the loop, 2) it's possible to break out of the loop because of the count--so I think you need to assert that the file actually ends with .mp3 just as you assert that it is playing.

review: Needs Fixing

« Back to merge proposal