Code review comment for lp:~nskaggs/music-app/fix-shuffle-test

Revision history for this message
Victor Thompson (vthompson) wrote :

I don't know if I agree with the next and previous changes. It looks like you attempted to harden then against failure, but at the same time it looks like you've made it almost impossible for the tests to fail. IMO it should not loop through 10 times and hit the forward/back button until it hits it's target. These are not randomized like shuffle so if it doesn't work the first try the test should fail. Or am I missing something?

review: Needs Fixing

« Back to merge proposal