Code review comment for lp:~nskaggs/music-app/fix-shuffle-test

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Victor, thanks for commenting. I knew you would probably find an issue with the implementation which is why I asked. I must admit shuffle has been a source of confusion for me with the music app :-)

"We need to confirm that the next track is NOT what would have otherwise came next. "

^^ This is a good point. Your view of what I'm doing is correct. It's possible the original implementation would work now with the tweaks made, but I like your idea of hitting next and previous while toggling shuffle. I'll implement that and see what it looks like.

« Back to merge proposal