Code review comment for lp:~nskaggs/music-app/fix-shuffle-test

Revision history for this message
Victor Thompson (vthompson) wrote :

Can you explain the shuffle test changes? It looks like you're checking just to see if the song has changed to confirm that your "shuffled" variable is true. This is incorrect--hitting next when shuffle is off also changes the currently playing song. We need to confirm that the next track is NOT what would have otherwise came next. Then it looks like you keep hitting forward until you get to the original track. What does that prove?

maybe a decent strategy would be to hit forward, turn off shuffle, hit back, if the current track is the original track then shuffle hasn't been verified so we try again (currently up to 100 times).

review: Needs Fixing

« Back to merge proposal