Code review comment for lp:~nskaggs/juju-release-tools/add-daily-build

Hi Nicholas.

After reading this code again. I don't think we need to rename the tarfile. In stead we want to pass a revised version to create_source_package_branch().

1. The call to import-upstream uses version because the upstream tar file is not guaranteed to be debian friendly. The "version" we pass is used to bzr to recreate the orig tarfile as needed.

2. The step to import the tarfile is done in its own sub dir (*.all-all) to keep it isolated from the dirs that make source packages.

3. I think is collides with the changes to create_source_package() which wants to make the source package version. :( Since the version, revid date etc was applied outside of create_source_package() it will make a mistake. Either we continue to pass the original version to this function, or we choose to make this function accept the version passed.

Sorry for advising you