Code review comment for lp:~nskaggs/juju-ci-tools/add-snap-to-default-juju-args

Revision history for this message
Aaron Bentley (abentley) wrote :

Thanks.

I'm a little unclear why you moved _generate_default_clean_dir, but I'm fine with it.

I do think that the leading underscore is incorrect. This is a public function meant to be invoked outside utility.py, not a private function. But that's a quibble.

review: Approve

« Back to merge proposal