juju-ci-tools

Code review comment for lp:~nskaggs/juju-ci-tools/add-snap-to-default-juju-args

  1. add-snap-to-default-juju-args
  2. Merge into trunk
Revision history for this message
Aaron Bentley (abentley) wrote :

I don't think this is right. If there is a default juju, it should be the juju returned by "which juju", i.e. the one in your PATH. If you have the snap installed, the snap juju should be in your PATH.

client_from_config already gives you this value if juju_path is None.

review: Needs Fixing

« Back to merge proposal